Use super parameters in more places, linted by the analyzer#9815
Merged
srawlins merged 2 commits intoflutter:masterfrom Apr 30, 2026
Merged
Use super parameters in more places, linted by the analyzer#9815srawlins merged 2 commits intoflutter:masterfrom
srawlins merged 2 commits intoflutter:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the _TestScreen constructor across several test files to use Dart's super-initializer parameters, improving conciseness. A concern was raised regarding the showFloatingDebuggerControls parameter in scaffold_debugging_controls_test.dart, which is currently unused and should be removed for consistency with the other refactored files.
kenzieschmoll
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a breakage in CI: https://github.com/flutter/devtools/actions/runs/25175731644/job/73807795671?pr=9814
A few parameters are also just removed, as they became seen as "unused," and no calls to the constructor passes a value for the parameter.